-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[common][core][format] Support using file index result for RowGroup filtering. #4473
Merged
JingsongLi
merged 8 commits into
apache:master
from
hang8929201:bitmap_as_rowgroup_filter
Nov 11, 2024
Merged
[common][core][format] Support using file index result for RowGroup filtering. #4473
JingsongLi
merged 8 commits into
apache:master
from
hang8929201:bitmap_as_rowgroup_filter
Nov 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Nov 7, 2024
paimon-core/src/main/java/org/apache/paimon/operation/RawFileSplitRead.java
Outdated
Show resolved
Hide resolved
JingsongLi
requested changes
Nov 8, 2024
paimon-common/src/main/java/org/apache/paimon/format/FormatReaderContext.java
Outdated
Show resolved
Hide resolved
paimon-common/src/main/java/org/apache/paimon/format/FormatReaderContext.java
Outdated
Show resolved
Hide resolved
paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexPredicate.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/operation/RawFileSplitRead.java
Show resolved
Hide resolved
paimon-format/src/main/java/org/apache/paimon/format/parquet/ParquetUtil.java
Outdated
Show resolved
Hide resolved
Left comments @hang8929201 |
hang8929201
force-pushed
the
bitmap_as_rowgroup_filter
branch
from
November 11, 2024 02:18
a6ec503
to
b8a4def
Compare
JingsongLi
reviewed
Nov 11, 2024
paimon-format/src/main/java/org/apache/paimon/format/orc/OrcReaderFactory.java
Outdated
Show resolved
Hide resolved
JingsongLi
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @hang8929201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Use file index result(bitmap) for more fine-grained IO clipping in the reader.
Tests
This is a query in our real business scenario.
API and Format
Documentation